fix copy buttons, email filter #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
carlosgauci
commented
Dec 30, 2022
carlosgauci
commented
- Fixed copy buttons from breaking when no language is specified
- Modified newsletter email filter to allow "+"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Many thanks @carlosgauci - LGTM 🙌🏽 |
TuanaCelik
reviewed
Dec 30, 2022
There was a problem hiding this comment.
Thanks @carlosgauci - It works now. There's a scenario where it doesn't though. If the email already has a '.' (like our work emails 😄 )
e.g.: [email protected]]
Apart from that all good. Will merge asap
Sorry about that, should work now :) |
TuanaCelik
approved these changes
Dec 30, 2022
This was
linked to
issues
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.