Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting fix for twitter cards #45

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Attempting fix for twitter cards #45

merged 1 commit into from
Nov 4, 2022

Conversation

TuanaCelik
Copy link
Member

Attempts to fix #44

@vercel
Copy link

vercel bot commented Nov 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
haystack-home ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 10:43PM (UTC)

@TuanaCelik
Copy link
Member Author

I'm not sure this worked :D

Copy link
Collaborator

@carlosgauci carlosgauci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to have worked on the preview :)

@bilgeyucel
Copy link
Collaborator

Do we need to update the og:image as well?

@TuanaCelik
Copy link
Member Author

No the of image is fine, it can handle relative paths. But turns out Twitter requires absolute 🤦🏽‍♀️

Let's try this.. if not we can do other minor fixes :)

@TuanaCelik TuanaCelik merged commit 6e89547 into main Nov 4, 2022
@TuanaCelik TuanaCelik deleted the twitter-card branch November 4, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twitter meta image
3 participants