add benchmark versions #54
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
content/benchmarks/_index.md
Outdated
| @@ -3,4 +3,5 @@ layout: benchmarks | |||
| header: dark | |||
| footer: dark | |||
| title: Haystack Benchmarks | |||
| version: latest | |||
There was a problem hiding this comment.
Can we maybe use a "real" version here? So that we don't need to have a latest folder that would be overwritten every time we add a new version
There was a problem hiding this comment.
Additionally to that, does it make sense to make the version number come up so that we can access the 'latest' version via it's version tag too? E.g. now it would be: https://haystack-home-git-benchmark-versions-deepset-overnice.vercel.app/benchmarks/v1.9.0
Which would also be accessible on https://haystack-home-git-benchmark-versions-deepset-overnice.vercel.app/benchmarks
And @masci do I understand correctly that here we would edit the _index.md file to include the actual latest version numner?
E.g.:
version: v1.9.0 --> this version becomes the one shown in .../benchmarks
| {{ $retrieverPerformance := .Site.Data.benchmarks.retriever_performance }} | ||
| {{ $retrieverAccuracy := .Site.Data.benchmarks.retriever_map }} | ||
| {{ $retrieverSpeed := .Site.Data.benchmarks.retriever_speed }} | ||
| {{ $versions := (slice "v0.10.0" "v0.9.0" "v0.8.0" "v0.7.0" "v0.6.0" "v0.5.0" ) }} |
There was a problem hiding this comment.
Only if it's an easy fix, because it's quite a detail so no problem if not. If there's a way to automate this depending on what folders exist that would be nice. But as this won't be very frequent ok to keep this, let's just add instructions to the readme about how to add a new benchmark to the site.
|
@masci @TuanaCelik I've updated it as requested, to add a new benchmark you can add a new markdown file for the page in the benchmarks folder, and update the version on the _index.md file so it will also be used on the /benchmarks page. |
There was a problem hiding this comment.
This looks really good to me thanks @carlosgauci
From my side, let's merge the sitemap exclude PR first and update this one accordingly. Then I'm good with this to be merged :)
WDYT @masci ?
Added versions to the Benchmarks page.