Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastiscsearch BM25Retriever: set scale_score default value to False #50

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Elastiscsearch BM25Retriever: set scale_score default value to False #50

merged 3 commits into from
Nov 14, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Nov 13, 2023 •
edited
Loading

Related to deepset-ai/haystack#6271

(I also fixed a test that used text instead of content in Document initialization).

@anakin87 anakin87 changed the title Elastiscsearch Retriever: set scale_score default value to False Elastiscsearch BM25Retriever: set scale_score default value to False Nov 13, 2023
@anakin87 anakin87 marked this pull request as ready for review November 13, 2023 11:15
@anakin87 anakin87 requested a review from a team as a code owner November 13, 2023 11:15
@anakin87 anakin87 requested review from ZanSara and silvanocerza and removed request for a team November 13, 2023 11:15
@anakin87 anakin87 merged commit 5d77ec4 into main Nov 14, 2023
4 checks passed
@anakin87 anakin87 deleted the scale-score-false branch November 14, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@ZanSara ZanSara Awaiting requested review from ZanSara ZanSara is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @silvanocerza