Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qdrant - refactor and release a major version #676

Closed
anakin87 opened this issue Apr 22, 2024 · 2 comments
Closed

Qdrant - refactor and release a major version #676

anakin87 opened this issue Apr 22, 2024 · 2 comments

Comments

@anakin87
Copy link
Member

anakin87 commented Apr 22, 2024

important

  • the embedding_field init parameter of QdrantDocumentStore will break things if not set to the default value ("embedding") -> should be removed
  • the return_embedding init parameter of QdrantDocumentStore is not used and is confusing -> should be removed
    EDIT: I was wrong, it is used

nice to have

  • set the default value for scale_score in Retrievers to False, as we do for all other retrievers
  • separate well the tests for Document Store retrieval methods and Retrievers (non breaking)
@anakin87
Copy link
Member Author

anakin87 commented Jun 18, 2024

Also the init parameter duplicate_documents is not used and should be removed.

@anakin87
Copy link
Member Author

anakin87 commented Jul 2, 2024

done in #861 and #862

released a new major version of the package: https://pypi.org/project/qdrant-haystack/4.0.0/

@anakin87 anakin87 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants