Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance / endpoint #5

Closed
srini047 opened this issue Mar 18, 2024 · 3 comments · Fixed by #10
Closed

Enhance / endpoint #5

srini047 opened this issue Mar 18, 2024 · 3 comments · Fixed by #10
Labels
enhancement New feature or request

Comments

@srini047
Copy link
Contributor

Currently if the server starts I go to http:https://localhost:1416/ which is the root of the server. But I get a empty response, which seems unsatisfying. Instead better to have a message to showcase.

Modifications to be done here:

I would like to take up this issue if that's fine.

@masci masci added the enhancement New feature or request label Apr 12, 2024
@masci
Copy link
Contributor

masci commented Apr 12, 2024

Hi @srini047 what info would you expect to see? Let's agree on what to show and I'll be happy to review a PR if you want to contribute the feature!

@srini047
Copy link
Contributor Author

Sure @masci
Atleast a very basic response:

{
  "message": "Sever is running"
}

Or something similar to the Github API.
For Haystack equivalent:

{
  "haystack_swagger_ui": "http:https://localhost:1416/docs",
  "haystack_deploy": "http:https://localhost:1416/deploy",
  "haystack_pipleine": "http:https://localhost:1416/pipeline",
}

Something like this. Which one do you prefer @masci?

@masci
Copy link
Contributor

masci commented Apr 12, 2024

@srini047 the first one is very similar to the /status endpoint, so I'd go with the second, a "summary" of the available endpoints might be helpful indeed

@masci masci linked a pull request Apr 18, 2024 that will close this issue
@masci masci closed this as completed in #10 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants