Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading Lyrics #223

Open
1 task
ChandanShakya opened this issue Mar 16, 2022 · 3 comments
Open
1 task

Downloading Lyrics #223

ChandanShakya opened this issue Mar 16, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@ChandanShakya
Copy link

Feature Request

Checklist

  • Add support for downloading synced lyrics

Description

I want to be able to have the lyrics downloaded alongside the song or manually.

@ChandanShakya ChandanShakya added the enhancement New feature or request label Mar 16, 2022
@deepjyoti30
Copy link
Owner

@ZXY-CC-3ag13 Most metadata providers do not provide lyrics and adding a whole different layer of provider just to fetch lyrics seems like an overkill considering most music players won't even recognize the lyrics stored as metadata.

I will keep the issue open in case more people seem to need this feature, they can discuss in this issue itself.

@cowpod
Copy link

cowpod commented Sep 8, 2022

spotDL manages to do this, and they download from youtube too.
not sure how though, looking at ffmpeg each line is suffixed with ":".
https://github.com/spotDL/spotify-downloader

@deepjyoti30
Copy link
Owner

@cowpod Thanks for letting us know. Seems like spotdl gets the data from Spotify only and since Spotify recently rolled out lyrics support for all countries (afaik), that is probably the reason why spotdl is able to do it.

However, in case of ytmdl, we let users select the metadata provider and we do support a lot of providers other than spotify and I am aware that as of now only Spotify and MusicBrainz provides lyrics which brings me back to the same reason that adding support for lyrics just for one or two providers doesn't seem like it's worth it.

Also, considering the basic metadata (like title, album name, singer name) are already being fetched, I think most music players will fetch the lyrics automatically (at least ncmpcpp does this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants