From 44c2d2f0a51f3d2c3b0ff85f02a5d2a248d4ee2e Mon Sep 17 00:00:00 2001 From: Till Rohrmann Date: Tue, 1 Mar 2016 17:21:57 +0100 Subject: [PATCH] [FLINK-3560] [examples] Remove unchecked output of usage statement in examples This closes #1752. --- .../apache/flink/examples/java/clustering/KMeans.java | 1 - .../org/apache/flink/examples/java/distcp/DistCp.java | 4 ++-- .../examples/java/graph/ConnectedComponents.java | 11 +---------- .../flink/examples/java/graph/EnumTriangles.java | 3 +-- .../apache/flink/examples/java/graph/PageRank.java | 11 +++++------ .../examples/java/graph/TransitiveClosureNaive.java | 10 +--------- .../flink/examples/java/ml/LinearRegression.java | 1 - .../java/relational/EmptyFieldsCountAccumulator.java | 1 - .../flink/examples/java/relational/TPCHQuery10.java | 1 - .../flink/examples/java/relational/TPCHQuery3.java | 2 +- .../examples/java/relational/WebLogAnalysis.java | 3 +-- .../flink/examples/java/wordcount/WordCount.java | 3 +-- .../flink/examples/scala/clustering/KMeans.scala | 2 -- .../examples/scala/graph/ConnectedComponents.scala | 3 --- .../flink/examples/scala/graph/EnumTriangles.scala | 2 -- .../flink/examples/scala/graph/PageRankBasic.scala | 3 --- .../examples/scala/graph/TransitiveClosureNaive.scala | 4 +--- .../flink/examples/scala/ml/LinearRegression.scala | 2 -- .../flink/examples/scala/relational/TPCHQuery10.scala | 1 - .../flink/examples/scala/relational/TPCHQuery3.scala | 1 - .../examples/scala/relational/WebLogAnalysis.scala | 1 - .../flink/examples/scala/wordcount/WordCount.scala | 2 -- .../streaming/examples/iteration/IterateExample.java | 1 - .../streaming/examples/kafka/WriteIntoKafka.java | 1 + .../examples/ml/IncrementalLearningSkeleton.java | 1 - .../examples/windowing/SessionWindowing.java | 1 - .../examples/windowing/TopSpeedWindowing.java | 1 - .../streaming/examples/windowing/WindowWordCount.java | 2 -- .../streaming/examples/wordcount/PojoExample.java | 1 - .../flink/streaming/examples/wordcount/WordCount.java | 1 - .../scala/examples/windowing/TopSpeedWindowing.scala | 2 -- .../src/main/java/SocketTextStreamWordCount.java | 1 - .../src/main/scala/SocketTextStreamWordCount.scala | 1 - 33 files changed, 15 insertions(+), 70 deletions(-) diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java index b2e9462f3d538..8e51df899ded2 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java @@ -82,7 +82,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: KMeans --points --centroids --output --iterations "); // set up execution environment ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java index 1d07c2d520549..82f1c52764d35 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java @@ -102,7 +102,8 @@ public static void main(String[] args) throws Exception { FlatMapOperator res = inputTasks.flatMap(new RichFlatMapFunction() { - + + private static final long serialVersionUID = 1109254230243989929L; private LongCounter fileCounter; private LongCounter bytesCounter; @@ -185,5 +186,4 @@ private static void getCopyTasks(Path p, String rel, List tasks) t } } } - } diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/ConnectedComponents.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/ConnectedComponents.java index a86cdfdeb60fc..3bd65222348a1 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/ConnectedComponents.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/ConnectedComponents.java @@ -19,7 +19,6 @@ package org.apache.flink.examples.java.graph; -import org.apache.flink.api.common.ProgramDescription; import org.apache.flink.api.common.functions.FlatJoinFunction; import org.apache.flink.api.common.functions.FlatMapFunction; import org.apache.flink.api.common.functions.JoinFunction; @@ -74,7 +73,7 @@ * */ @SuppressWarnings("serial") -public class ConnectedComponents implements ProgramDescription { +public class ConnectedComponents { // ************************************************************************* // PROGRAM @@ -84,7 +83,6 @@ public static void main(String... args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: ConnectedComponents --vertices --edges --output --iterations "); // set up execution environment ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); @@ -185,13 +183,6 @@ public void join(Tuple2 candidate, Tuple2 old, Collector } } - - - @Override - public String getDescription() { - return "Parameters: --vertices --edges --output --iterations "; - } - // ************************************************************************* // UTIL METHODS // ************************************************************************* diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTriangles.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTriangles.java index 33570fc9f44d4..5fbb32121c258 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTriangles.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/EnumTriangles.java @@ -82,7 +82,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: EnumTriangleBasic --edges --output "); // set up execution environment final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); @@ -124,7 +123,7 @@ public static void main(String[] args) throws Exception { triangles.print(); } } - + // ************************************************************************* // USER FUNCTIONS // ************************************************************************* diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/PageRank.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/PageRank.java index c613a7e4ddae4..33305af0abe00 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/PageRank.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/PageRank.java @@ -83,7 +83,6 @@ public class PageRank { public static void main(String[] args) throws Exception { ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: PageRankBasic --pages --links --output --numPages --iterations "); final int numPages = params.getInt("numPages", PageRankData.getNumberOfPages()); final int maxIterations = params.getInt("iterations", 10); @@ -135,7 +134,7 @@ public static void main(String[] args) throws Exception { } - + // ************************************************************************* // USER FUNCTIONS // ************************************************************************* @@ -147,7 +146,7 @@ public static final class RankAssigner implements MapFunction outPageWithRank; public RankAssigner(double rank) { - this.outPageWithRank = new Tuple2(-1l, rank); + this.outPageWithRank = new Tuple2(-1L, rank); } @Override @@ -189,9 +188,9 @@ public void flatMap(Tuple2, Tuple2> value, Co Long[] neighbors = value.f1.f1; double rank = value.f0.f1; double rankToDistribute = rank / ((double) neighbors.length); - - for (int i = 0; i < neighbors.length; i++) { - out.collect(new Tuple2(neighbors[i], rankToDistribute)); + + for (Long neighbor: neighbors) { + out.collect(new Tuple2(neighbor, rankToDistribute)); } } } diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/TransitiveClosureNaive.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/TransitiveClosureNaive.java index b4cf0364bf7cf..50e86ec4142f2 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/TransitiveClosureNaive.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/graph/TransitiveClosureNaive.java @@ -18,7 +18,6 @@ package org.apache.flink.examples.java.graph; -import org.apache.flink.api.common.ProgramDescription; import org.apache.flink.api.common.functions.CoGroupFunction; import org.apache.flink.api.common.functions.GroupReduceFunction; import org.apache.flink.api.common.functions.JoinFunction; @@ -34,13 +33,12 @@ import java.util.Set; @SuppressWarnings("serial") -public class TransitiveClosureNaive implements ProgramDescription { +public class TransitiveClosureNaive { public static void main (String... args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: TransitiveClosure --edges --output --iterations "); // set up execution environment ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); @@ -117,10 +115,4 @@ public void coGroup(Iterable> prevPaths, Iterable --output --iterations "; - } - } diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/LinearRegression.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/LinearRegression.java index d225215ebb415..90ad67a827789 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/LinearRegression.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/ml/LinearRegression.java @@ -73,7 +73,6 @@ public class LinearRegression { public static void main(String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: LinearRegression --input --output --iterations "); // set up execution environment final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/EmptyFieldsCountAccumulator.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/EmptyFieldsCountAccumulator.java index b6eba8fc0cd1e..87b5bff275d9f 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/EmptyFieldsCountAccumulator.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/EmptyFieldsCountAccumulator.java @@ -65,7 +65,6 @@ public static void main(final String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); - System.out.println("Usage: EmptyFieldsCountAccumulator --input --output "); // make parameters available in the web interface env.getConfig().setGlobalJobParameters(params); diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java index 816be1e01884f..14fbc34cf0cbf 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery10.java @@ -216,5 +216,4 @@ private static DataSet> getNationsDataSet(ExecutionEnvir .includeFields("1100") .types(Integer.class, String.class); } - } diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery3.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery3.java index e0bd536627eba..c849764e9de60 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery3.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/TPCHQuery3.java @@ -181,7 +181,7 @@ public ShippingPriorityItem join(ShippingPriorityItem i, Lineitem l) { } } - + // ************************************************************************* // DATA TYPES // ************************************************************************* diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/WebLogAnalysis.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/WebLogAnalysis.java index 677ca1cd2ce6d..5c8fac58d2bf2 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/WebLogAnalysis.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/relational/WebLogAnalysis.java @@ -102,7 +102,6 @@ public static void main(String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); final ExecutionEnvironment env = ExecutionEnvironment.getExecutionEnvironment(); - System.out.println("Usage: WebLogAnalysis --documents --ranks --visits --output "); env.getConfig().setGlobalJobParameters(params); @@ -147,7 +146,7 @@ public static void main(String[] args) throws Exception { result.print(); } } - + // ************************************************************************* // USER FUNCTIONS // ************************************************************************* diff --git a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java index b914d77416e81..8538a20eb6a7c 100644 --- a/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java +++ b/flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java @@ -62,7 +62,6 @@ public static void main(String[] args) throws Exception { // make parameters available in the web interface env.getConfig().setGlobalJobParameters(params); - System.out.println("Usage: WordCount --input --output "); // get input data DataSet text; @@ -94,7 +93,7 @@ public static void main(String[] args) throws Exception { } } - + // ************************************************************************* // USER FUNCTIONS // ************************************************************************* diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala index 78ce45b820952..e5a16a5178334 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala @@ -76,7 +76,6 @@ object KMeans { // checking input parameters val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: KMeans --points --centroids --output --iterations ") // set up execution environment val env: ExecutionEnvironment = ExecutionEnvironment.getExecutionEnvironment @@ -225,7 +224,6 @@ object KMeans { } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/ConnectedComponents.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/ConnectedComponents.scala index 2538aa68efd9e..c7186123c0e62 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/ConnectedComponents.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/ConnectedComponents.scala @@ -66,8 +66,6 @@ object ConnectedComponents { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: ConnectedComponents " + - "--vertices --edges --output --iterations ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -151,5 +149,4 @@ object ConnectedComponents { env.fromCollection(edgeData) } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/EnumTriangles.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/EnumTriangles.scala index 88037c5a5c971..0a59699d3b1d3 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/EnumTriangles.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/EnumTriangles.scala @@ -71,7 +71,6 @@ object EnumTriangles { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: EnumTriangleBasic --edges --output ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -156,5 +155,4 @@ object EnumTriangles { } } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/PageRankBasic.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/PageRankBasic.scala index 84ebff5610408..1f842d5b4b96a 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/PageRankBasic.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/PageRankBasic.scala @@ -75,8 +75,6 @@ object PageRankBasic { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: PageRankBasic " + - "--pages --links --output --numPages --iterations ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -183,5 +181,4 @@ object PageRankBasic { env.fromCollection(edges) } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/TransitiveClosureNaive.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/TransitiveClosureNaive.scala index d989969b1e24b..1f3a32b0a167c 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/TransitiveClosureNaive.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/graph/TransitiveClosureNaive.scala @@ -23,12 +23,11 @@ import org.apache.flink.api.scala._ import org.apache.flink.examples.java.graph.util.ConnectedComponentsData import org.apache.flink.util.Collector -object TransitiveClosureNaive { +object TransitiveClosureNaive { def main (args: Array[String]): Unit = { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: TransitiveClosure --edges --output --iterations ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -86,5 +85,4 @@ object TransitiveClosureNaive { } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala index eec84b917c3a1..4663db6800fa2 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/ml/LinearRegression.scala @@ -64,7 +64,6 @@ object LinearRegression { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: LinearRegression --input --output --iterations ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -157,5 +156,4 @@ object LinearRegression { (Params(theta0, theta1), 1) } } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery10.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery10.scala index 4962f2c19d216..f0d21f2723ea0 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery10.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery10.scala @@ -175,5 +175,4 @@ object TPCHQuery10 { fieldDelimiter = "|", includedFields = Array(0, 1) ) } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery3.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery3.scala index d157a75c7e5ce..d6d1846f0a352 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery3.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/TPCHQuery3.scala @@ -169,5 +169,4 @@ object TPCHQuery3 { fieldDelimiter = "|", includedFields = Array(0, 1, 4, 7) ) } - } diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/WebLogAnalysis.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/WebLogAnalysis.scala index 09e2d52d4b1a2..7ed39c9428112 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/WebLogAnalysis.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/relational/WebLogAnalysis.scala @@ -93,7 +93,6 @@ object WebLogAnalysis { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - println("Usage: --documents --ranks --visits --output ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment diff --git a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala index 7ce9d51de0c5b..0f3d6c8e1ff07 100644 --- a/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala +++ b/flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/wordcount/WordCount.scala @@ -48,7 +48,6 @@ object WordCount { def main(args: Array[String]) { val params: ParameterTool = ParameterTool.fromArgs(args) - System.out.println("Usage: WordCount --input --output ") // set up execution environment val env = ExecutionEnvironment.getExecutionEnvironment @@ -78,7 +77,6 @@ object WordCount { } } - } diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java index 67718cf3c3544..5859ad4e05d1f 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/iteration/IterateExample.java @@ -58,7 +58,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println(" Usage: IterateExample --input --output "); // set up input for the stream of integer pairs diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java index 63b37c4910e9a..37c86a3642860 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java @@ -49,6 +49,7 @@ public static void main(String[] args) throws Exception { // very simple data generator DataStream messageStream = env.addSource(new SourceFunction() { + private static final long serialVersionUID = 6369260445318862378L; public boolean running = true; @Override diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/ml/IncrementalLearningSkeleton.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/ml/IncrementalLearningSkeleton.java index 41084852f6486..f10c55e260a30 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/ml/IncrementalLearningSkeleton.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/ml/IncrementalLearningSkeleton.java @@ -61,7 +61,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: IncrementalLearningSkeleton --output "); StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime); diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/SessionWindowing.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/SessionWindowing.java index 27804feaa3c5b..61616febf32bc 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/SessionWindowing.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/SessionWindowing.java @@ -37,7 +37,6 @@ public static void main(String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); - System.out.println("Usage: SessionWindowing --output "); env.getConfig().setGlobalJobParameters(params); env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime); diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java index 8f0eb47f8ff33..df24008c45371 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java @@ -53,7 +53,6 @@ public class TopSpeedWindowing { public static void main(String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); - System.err.println("Usage: TopSpeedWindowingExample --input --output "); final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime); diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java index d6f7450a792e5..38fcd76fb4e45 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java @@ -53,7 +53,6 @@ public class WindowWordCount { public static void main(String[] args) throws Exception { final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println(" Usage: WindowWordCount --input --output --window --slide "); // set up the execution environment final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); @@ -96,5 +95,4 @@ public static void main(String[] args) throws Exception { // execute program env.execute("WindowWordCount"); } - } diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/PojoExample.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/PojoExample.java index d02324618a140..8c16172727477 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/PojoExample.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/PojoExample.java @@ -52,7 +52,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: PojoExample --input --output "); // set up the execution environment final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); diff --git a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/WordCount.java b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/WordCount.java index a143fa5cff371..4290878dab02d 100644 --- a/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/WordCount.java +++ b/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/wordcount/WordCount.java @@ -56,7 +56,6 @@ public static void main(String[] args) throws Exception { // Checking input parameters final ParameterTool params = ParameterTool.fromArgs(args); - System.out.println("Usage: WordCount --input --output "); // set up the execution environment final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); diff --git a/flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/TopSpeedWindowing.scala b/flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/TopSpeedWindowing.scala index 3a75a496f8027..80881cc575d60 100644 --- a/flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/TopSpeedWindowing.scala +++ b/flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/TopSpeedWindowing.scala @@ -58,7 +58,6 @@ object TopSpeedWindowing { def main(args: Array[String]) { val params = ParameterTool.fromArgs(args) - println("Usage: TopSpeedWindowing --input --output ") val env = StreamExecutionEnvironment.getExecutionEnvironment env.getConfig.setGlobalJobParameters(params) @@ -124,5 +123,4 @@ object TopSpeedWindowing { val record = line.substring(1, line.length - 1).split(",") (record(0).toInt, record(1).toInt, record(2).toDouble, record(3).toLong) } - } diff --git a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java index 10d804426c769..6a3383c73cd18 100644 --- a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java +++ b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/src/main/java/SocketTextStreamWordCount.java @@ -84,7 +84,6 @@ public static void main(String[] args) throws Exception { // execute program env.execute("WordCount from SocketTextStream Example"); } - // // User Functions // diff --git a/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/SocketTextStreamWordCount.scala b/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/SocketTextStreamWordCount.scala index 9bc85eabcde76..d08974dd0a831 100644 --- a/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/SocketTextStreamWordCount.scala +++ b/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/src/main/scala/SocketTextStreamWordCount.scala @@ -66,5 +66,4 @@ object SocketTextStreamWordCount { env.execute("Scala SocketTextStreamWordCount Example") } - }