-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it a PWA #573
Comments
Hi @btahir First of thank you for taking the time writing this!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature request
Gatsby apps are PWAs pretty much out of the box with the help of a couple of plugins. Is there a reason why this has not been implemented? You just need to add the gatsby-plugin-manifest and gatsby-plugin-offline plugins. This is how it looks in gatsby-config:
I went ahead and implemented this in my own version and hit a snag because of a viewport error. Turns out the footer is exceeding the viewport width which triggers an error in Lighthouse. To fix this you need to set a max-width of 100vw on <div className="columns> in the Footer component.
Hope this helps!
The text was updated successfully, but these errors were encountered: