-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add favicon/manifest #191
Comments
Sorry for getting back to you so late, i do think it makes sense having that plugin in the repo. |
@ZoltanVeres Not late at all! I'll make a PR for this tonight or maybe tomorrow. Thanks for the links! It looks like one of those SVGs contains a coffee cup, so I'll try to pull it out (or trace it if that's not possible). |
This is my favourite site nowadays, you can definitely use this as favicon / icon if you like https://favicon.io/emoji-favicons/hot-beverage/ |
@missmatsuko Does this means that the |
Sorry about my last comment, I was looking at the wrong repo. I couldn't find a way to find out how long the favicon generating part takes, but I tried building the demo site a few times with and without the plugin and I think it's around 2-4 seconds, with the total build ranging from 16-20 seconds. Is that a terribly long time? I would think that Purge CSS and Gatsby Image (which resizes pretty much all the raster images) would take a lot longer than this Favicon thing. I saw that gatsby-plugin-offline is recommended to use with this. I'm not sure if it would help, especially in conjunction with Netlify: |
I was checking your PR and the build took ~6 mins in Netlify, the reason that it runs fast on your machine is that the gatsby-manifest-plugin is using As a side note: I think, from our usecase we should only run the manifest generation when |
I can make that change. gatsby-image also uses sharp, and that would likely be used to resize all the content images on a production site. Those generated images are not committed, either. I'm surprised the favicon generation takes so long in comparison. |
name: Feature request
about: Suggest an idea for this project
Feature request
What is the expected behavior?
Generate different sizes favicons from one source SVG and create a manifest.
What is motivation or use case for adding/changing the behavior?
Don't have to manually create and commit different favicon sizes and include them in helmet. I think most people would want to configure a web app manifest as well.
How should this be implemented in your opinion?
Use gatsby-plugin-manifest.
I gave it a try and it seemed to work fine just by adding it into plugins. I thought there might be some issues with helmet, but seem ok.
This is the configuration I used. I guess the current coffee cup favicon will need to be recreated as an SVG, unless someone knows the source?
Are you willing to work on this yourself?
yes
The text was updated successfully, but these errors were encountered: