Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logo_url appears not to be used when local_backend:true #5752

Closed
paulmsmith opened this issue Aug 26, 2021 · 3 comments · Fixed by #7235
Closed

logo_url appears not to be used when local_backend:true #5752

paulmsmith opened this issue Aug 26, 2021 · 3 comments · Fixed by #7235
Labels
area: extensions/backends area: local-proxy good first issue type: bug code to address defects in shipped code

Comments

@paulmsmith
Copy link

Describe the bug
The login screen when config option local_backend: true does not load the custom logo which is set using logo_url option. It still shows the NetlifyCMS logo. however It does show the custom logo when local_backend: false

To Reproduce
Update the config.yml file for your NelifyCMS instance to have a custom logo and be set to local_backend true:

Expected behavior
Logo to change to use custom logo on the login screen.

Applicable Versions:

  • Netlify CMS version: [e.g. 2.0.4]
  • Git provider: Github
  • OS: MacOS 11.5.1
  • Browser version [e.g. chrome 22, safari 11] - Version 92.0.4515.159 (Official Build) (x86_64)
  • Node.JS version: 15

CMS configuration

# Docs: https://www.netlifycms.org/docs/configuration-options/
backend:
  name: github
  branch: main
  repo: user-name/content-site # cms repo
  base_url: https://servicename.herokuapp.com # OAuth server
# when true will assume netlify-cms-proxy-server running: npx netlify-cms-proxy-server
local_backend: true
logo_url: /assets/images/logo.svg
publish_mode: editorial_workflow
public_folder: /assets/images
media_folder: assets/images/uploads
display_url: https://site-url.com/
site_url: https://site-url.com/
collections:
  - name: "guidance"
    label: "Guidance pages"
    label_singular: "Guidance page"
    folder: "app/content/guidance"
    create: true
    slug: "{{slug}}"
    fields:
      - { label: "Title", name: "title", widget: "string" }
      - { label: "Publish Date", name: "date", widget: "datetime" }
      - { label: "Description", name: "description", widget: "text" }
      - { label: "Body", name: "body", widget: "markdown" }
editor:
    preview: true

Perhaps a notable difference from the average user is that we're using an external OAuth Client written in Node because we had to use Heroku.
@paulmsmith paulmsmith added the type: bug code to address defects in shipped code label Aug 26, 2021
@paulmsmith paulmsmith changed the title logo_url appears not to be used when local_backend is true logo_url appears not to be used when local_backend:true Aug 26, 2021
@paulmsmith
Copy link
Author

This is a minor issue in the grand scheme of things but did confuse me for a little while.

@KoljaTM
Copy link
Contributor

KoljaTM commented Oct 9, 2021

It seems to me that this is only the case, when
backend:
name: test-repo
is used. When pasting the config.yml posted above into dev-test/config.yml it seems to work

@razonyang
Copy link
Contributor

Encounter same issue.

@MichalRsa MichalRsa mentioned this issue Jun 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: extensions/backends area: local-proxy good first issue type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: display custom logo when using a proxy server MichalRsa/decap-cms
4 participants
@paulmsmith @KoljaTM @razonyang @erezrokah