Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oletools unable to install because of Pyparsing version problem #762

Open
noadekel-DI opened this issue Apr 26, 2022 · 6 comments
Open

Oletools unable to install because of Pyparsing version problem #762

noadekel-DI opened this issue Apr 26, 2022 · 6 comments
Assignees
Milestone

Comments

@noadekel-DI
Copy link

Affected tool:
general oletools

Describe the bug
When trying to install, pip cannot find Pyparsing in version below 3.0 (tried to install manually and upgrade pip, nothing works) and thus unable to install.

Console output / Screenshots
ERROR: Could not find a version that satisfies the requirement pyparsing<3,>=2.1.0 (from oletools) (from versions: 3.0.8)
ERROR: No matching distribution found for pyparsing<3,>=2.1.0

Version information:

  • OS: Linux
  • OS version: Ubuntu 20.04.4 LTS
  • Python version: 3.9
  • oletools version: latest
@decalage2 decalage2 self-assigned this Apr 26, 2022
@decalage2 decalage2 added this to the oletools 0.60 milestone Apr 26, 2022
@jloehel
Copy link
Contributor

jloehel commented May 15, 2023

@decalage2 Can you please explain why it was necessary to avoid pyparsing 3+ in 750859c. 2020 pyparsing 3+ was only available in a early alpha. Was this the reason?

@vEpiphyte
Copy link
Contributor

@jloehel You can see a comment from declage2 here #812

@jloehel
Copy link
Contributor

jloehel commented May 17, 2023

@jloehel You can see a comment from declage2 here #812

Thanks for the hint. I am not sure if I understand the argument here. Oletools does not depend on ViperMonkey. ViperMonkey requires oletools. It should be enough to add the restriction to ViperMonkey. If oletools runs with pyparsing 2.x and 3.x it's fine.

@vEpiphyte
Copy link
Contributor

It is a bit confusing, since vipermonkey does have its own pyparsing constraint.

@decalage2
Copy link
Owner

Yes, it's just that I haven't touched the pyparsing code in olevba for years, and I don't know if it runs fine with the latest pyparsing versions. After some testing with different VBA samples, if it works we can relax the requirement to allow pyparsing 3.

@DManowitz
Copy link

Would also like a version that works with pyparsing 3.x. Any word on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants