Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting special periods and treatment interruptions #100

Open
ddediu opened this issue Jul 4, 2019 · 2 comments
Open

Plotting special periods and treatment interruptions #100

ddediu opened this issue Jul 4, 2019 · 2 comments

Comments

@ddediu
Copy link
Owner

ddediu commented Jul 4, 2019

Hi Sam,

unless I am missing something, to make it easier to add special periods to the CMA plot, I was wondering what you think about adding the special_periods part of the compute_event_durations() output:

  • the METHOD (even if it means just copying the special.periods.method value or adding its actual values if "custom")
  • if you do that, I am not sure I see why the CUSTOM column would still be needed anymore (it would be redundant)
  • SPECIAL.DURATION: I don't see it here, but seems to be included in the event_durations part of the output?

Also, are treatment interruptions also included in this special_periods or not? If so, maybe it would be good to somehow mark them as different from other special periods?

The advantage of all this is that I can have all the info packed in a single data.frame that I pass to the plot.CMA() function on top of the the CMA object...

Thanks,
Dan

@Masswear
Copy link
Collaborator

Masswear commented Jul 5, 2019

Add class "event_durations" to output of compute_event_durations and attribute for carryover.
Consider #85 for plotting.

@ddediu
Copy link
Owner Author

ddediu commented Jul 7, 2019

Ok +

  • one can pass directly a event_durations object to the CMAx() functions, and the created CMA objects are aware of the specific event_durations stuff
  • if event_durations was computed with carryover but is used with a CMA that is not aware of carryover, a warnings/error is thrown
  • plotting such a CMA object makes use of the event_durations info to show potential special periods etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants