Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connector field name #137

Merged
merged 2 commits into from
Sep 28, 2017
Merged

Conversation

seanmrogers
Copy link
Contributor

@seanmrogers seanmrogers commented Sep 26, 2017

Changes

  • A field name was incorrect, causing retries to fail when searching for connectorName which should be destination-connector

Testing

  • created some retries for forklift to pick up, confirmed old version failed with Unable to read result and that the this version doesn't fail.

Please Review

@Kuroshii @dcshock @AFrieze

Not sure how the versioning of this project works, let me know if I need to make changes.

@Kuroshii Kuroshii self-requested a review September 27, 2017 01:23
Copy link
Collaborator

@Kuroshii Kuroshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2,7 +2,7 @@ organization := "com.github.dcshock"

name := "forklift-retry"

version := "2.0"
version := "2.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 2.2 since forklift already has a version 2.1. We just haven't been bumping the version if there are no changes.

@Kuroshii Kuroshii merged commit 497a61e into dcshock:develop Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants