Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - implement support for DICOM-RTSS #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dxlin
Copy link

@dxlin dxlin commented Aug 29, 2022

start for RTSS support, add derivations, adapter, and updated dictionary. Requires relevant support from cornerstone3D (also WIP).

@@ -0,0 +1,470 @@
import { DicomMetaDictionary } from "../DicomMetaDictionary.js";

const _attributesToInclude = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style note: in dcmjs we avoid putting hex in the source code. Can you replace these with tokens from the metadata dictionary and convert them on the fly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just wanted to clarify what you are referring to when you say token. For example on the first entry in the dictionary.js, would it be "(0000,0002)" or "CommandGroupLength"?

Should I also make this change for src/sr/documents.js?

Thanks,
-dxlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants