Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch between latest value and current value and current club and last club #137

Open
BenoitLondon opened this issue Jan 9, 2023 · 0 comments
Labels
bug Something isn't working dataset

Comments

@BenoitLondon
Copy link

BenoitLondon commented Jan 9, 2023

(extracted from #136 )
those mismatches are probably due to the logic in the scraper but the current value is the one from the last team that was in in the scraped competitions IIUC.
If a player moved to another competition which is not scraped the current value in players.csv is wrong and current_club as well cf Teksen again (current_club is static as well, would be nice to have the current_club matched to the valuation date)
In Teksen case he has one month period with no club but his valuation does not change, would be great to add that as well in his valuation history

> kvalues[player_id == 411646]
         date   datetime   dateweek player_id current_club_id market_value player_club_domestic_competition_id
1: 2018-12-21 2018-12-21 2018-12-17    411646             369        25000                                 DK1
2: 2020-07-31 2020-07-31 2020-07-27    411646             369       100000                                 DK1
3: 2020-12-23 2020-12-23 2020-12-21    411646             369        50000                                 DK1
4: 2021-05-31 2021-05-31 2021-05-31    411646             369        50000                                 DK1
5: 2022-02-14 2022-02-14 2022-02-14    411646             369        25000                                 DK1
6: 2022-06-20 2022-06-20 2022-06-20    411646             369        50000                                 DK1

> kplayers[player_id == 411646]
   player_id            name current_club_id current_club_name country_of_citizenship country_of_birth city_of_birth date_of_birth
1:    411646 Ertugrul Teksen             369         Lyngby Bk                 Turkey          Denmark       Ishøj      2000-04-25
   position   sub_position foot height_in_cm market_value_in_gbp highest_market_value_in_gbp agent_name contract_expiration_date
1:   Attack Centre-Forward Left          185               25000                       1e+05                          2024-06-30
   current_club_domestic_competition_id first_name last_name     player_code
1:                                  DK1   Ertugrul    Teksen ertugrul-teksen
                                                                           image_url last_season
1: https://img.a.transfermarkt.technology/portrait/header/411646-1644520218.png?lm=1        2020
                                                                     url
1: https://www.transfermarkt.co.uk/ertugrul-teksen/profil/spieler/411646

Thank you for the massive job!

@dcaribou dcaribou added bug Something isn't working dataset labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataset
Projects
None yet
Development

No branches or pull requests

2 participants