Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First name // Last name in different columns #129

Closed
dcaribou opened this issue Dec 28, 2022 · 0 comments · Fixed by #131
Closed

First name // Last name in different columns #129

dcaribou opened this issue Dec 28, 2022 · 0 comments · Fixed by #131
Labels
dataset enhancement New feature or request

Comments

@dcaribou
Copy link
Owner

Moved from dcaribou/transfermarkt-scraper#47

Hi again,

I've noticed that Transfermarkt formats first name and last names differently in their pages- last names are given the "strong" tag, whereas first names are not

It would be great to gather these, for a number of reasons:

It's tidier to separate out the two variables (first name, last name) into different columns
as the examples above illustrate, it's not always clear where the first name(s) end and the last name(s) start
names sometimes contain dashes, which seem to be missed by the current approach

207570934-b62db823-b6c4-42ab-958d-b60906142001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant