Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2189] Remove required version: 2 and config-version: 2 #7054

Closed
4 tasks done
Tracked by #6747
jtcohen6 opened this issue Feb 27, 2023 · 2 comments · Fixed by #7060
Closed
4 tasks done
Tracked by #6747

[CT-2189] Remove required version: 2 and config-version: 2 #7054

jtcohen6 opened this issue Feb 27, 2023 · 2 comments · Fixed by #7060
Assignees
@dave-connors-3
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! model_versions paper_cut A small change that impacts lots of users in their day-to-day

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 27, 2023 •
edited
Loading

Copying from #6736

Justification

  • The version: 1 yaml file spec hasn't been supported for years! & version: 3 is unlikely to arrive anytime soon.
  • config-version: 2 for dbt_project.yml arrived in v0.17 (mid 2020), and config-version: 1 hasn't been supported since v0.19 (Jan 2021)
  • These are going to be even more confusing when we roll out model versions!

Implementation
@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! paper_cut A small change that impacts lots of users in their day-to-day model_versions enhancement New feature or request Team:Language labels Feb 27, 2023
@github-actions github-actions bot changed the title Remove required version: 2 and config-version: 2 [CT-2189] Remove required version: 2 and config-version: 2 Feb 27, 2023
@dave-connors-3 dave-connors-3 mentioned this issue Feb 27, 2023
Merged
6 tasks
@AndyBys
Copy link
Contributor

AndyBys commented Feb 27, 2023 •
edited
Loading

Hey! I am fairly new to open source, but would be happy to contribute. Can I help with the issue? :)

@jtcohen6 jtcohen6 mentioned this issue Mar 2, 2023
Closed
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Mar 2, 2023

@AndyBys really appreciate the offer to help! @dave-connors-3 has already picked this one up

You can check out some of the other issues labeled good_first_issue and help_wanted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dave-connors-3 dave-connors-3

Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! model_versions paper_cut A small change that impacts lots of users in their day-to-day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make version configs optional dbt-labs/dbt-core
3 participants
@jtcohen6 @AndyBys @dave-connors-3