Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typings when using type module #66

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Marsup
Copy link
Contributor

@Marsup Marsup commented Apr 22, 2024

This module doesn't work when enabling ESM with TS, see https://arethetypeswrong.github.io/?p=fast-safe-stringify%402.1.1
I just applied their advice.

It might close #65 but I'm not entirely sure.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2a96723 into davidmarkclements:master Apr 22, 2024
@Marsup Marsup deleted the fix/module-typings branch April 22, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type module support
2 participants