-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throwing PosDefException
in the corner cases
#49
Comments
Hello, so you suggest that the exception should not be thrown, and instead no update of the components should take place? |
Hello, yes, I would rather give a warning or something similar. Right now it just throws and you have an inconsistently changed argument structure if I understand correctly. A similar situation takes place with deprecated |
I just ran into |
In the case when some of the components don't have enough data points throws
PosDefException: matrix is not positive definite; Cholesky factorization failed.
rather than avoiding to update those components (which seems more practical) and showing a warning.
The text was updated successfully, but these errors were encountered: