Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing PosDefException in the corner cases #49

Open
kirill-kondrashov opened this issue Feb 28, 2020 · 3 comments
Open

Throwing PosDefException in the corner cases #49

kirill-kondrashov opened this issue Feb 28, 2020 · 3 comments

Comments

@kirill-kondrashov
Copy link

In the case when some of the components don't have enough data points throws
PosDefException: matrix is not positive definite; Cholesky factorization failed.
rather than avoiding to update those components (which seems more practical) and showing a warning.

@davidavdav
Copy link
Owner

Hello,

so you suggest that the exception should not be thrown, and instead no update of the components should take place?

@kirill-kondrashov
Copy link
Author

kirill-kondrashov commented Mar 2, 2020

Hello,

yes, I would rather give a warning or something similar. Right now it just throws and you have an inconsistently changed argument structure if I understand correctly. A similar situation takes place with deprecated ind2sub function call when the amount of data per cluster is not enough as well, but that's a separate bug, I think.

@harryscholes
Copy link

I just ran into ind2sub not defined. Possibly because all of my data was in one cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants