Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): move from HOCON to YAML POJO #2

Open
ebuildy opened this issue Jan 20, 2022 · 0 comments
Open

feat(config): move from HOCON to YAML POJO #2

ebuildy opened this issue Jan 20, 2022 · 0 comments
Assignees
@ebuildy
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ebuildy
Copy link
Contributor

ebuildy commented Jan 20, 2022

Actuellement on utlise le format HOCON (un JSON on steroid), ça marche bien, mais ça pose des soucis:

clareté du code: l'accès à la data se faisaint avec des getter de getter
config format schema-less : gros bordel pour bien écrire
Comme on fait déjà du YAML pour les définitions de pipeline, ça parait logique de bouger sur ça.

Il faudra quand même conserver la possibilité d'overrider une config via une variable d'env.
@ebuildy ebuildy self-assigned this Sep 19, 2022
@ebuildy ebuildy added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 19, 2022
@ebuildy ebuildy added this to the 6 milestone Sep 19, 2022
@ebuildy ebuildy removed this from the 6 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebuildy ebuildy

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebuildy