Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #141: add phone field and change delimiter #145

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

augusto-herrmann
Copy link
Collaborator

The following problems were fixed in the Italy import script (solves #141):

  • the phone field was missing from the generated data;
  • the csv dialect was set to autodetect, but failed to properly detect the delimiter. Solved by manually setting delimiter to tabs and setting encoding to utf-8-sig (was getting extraneous \ufeff character in the beginning.

@augusto-herrmann augusto-herrmann added the Data Data sources and ingestion automation label Mar 28, 2022
@augusto-herrmann augusto-herrmann linked an issue Mar 28, 2022 that may be closed by this pull request
@augusto-herrmann augusto-herrmann merged commit 69cc92c into master Mar 29, 2022
@augusto-herrmann augusto-herrmann deleted the fix-import-italy branch March 29, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Data sources and ingestion automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix IT import script
1 participant