[DNM] Don't queue resource tasks; wait for availability #6468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait to schedule resource-consuming tasks until the resource is actually available. Currently, we oversaturate (queue tasks) on workers that have the resource, even if it's currently in use.
This is just a proof-of-concept and should not actually be merged—the logic for scheduling
no-worker
tasks in_remove_from_processing
is way too inefficient. And obviously, we first need to discuss whether #6467 is intended behavior or not.I wrote this just so @TomNicholas could try it out with #6360 and see how much it improves things.
Closes #6467
pre-commit run --all-files