From 376bc3482e6cf90775c1bb4c551ffccffcd0d572 Mon Sep 17 00:00:00 2001
From: dartungar <dartungar@gmail.com>
Date: Sun, 31 Mar 2024 22:37:32 +0400
Subject: [PATCH] improve handling of empty queues

---
 manifest.json               |  2 +-
 src/queues/reviewService.ts | 11 +++--------
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/manifest.json b/manifest.json
index 37a02b6..4117fc3 100644
--- a/manifest.json
+++ b/manifest.json
@@ -1,7 +1,7 @@
 {
 	"id": "simple-note-review",
 	"name": "Simple Note Review",
-	"version": "1.2.4",
+	"version": "1.2.5",
 	"minAppVersion": "1.1.0",
 	"description": "Simple, customizable plugin for easy note review, resurfacing  & repetition.",
 	"author": "dartungar",
diff --git a/src/queues/reviewService.ts b/src/queues/reviewService.ts
index 8cc31cf..21b36c6 100644
--- a/src/queues/reviewService.ts
+++ b/src/queues/reviewService.ts
@@ -75,8 +75,6 @@ export class ReviewService {
 		await this.openNextNoteInQueue(noteSet);
 	}
 
-
-
 	private async removeNoteFromQueue(
 		note: TAbstractFile,
 		noteSet: INoteSet
@@ -86,12 +84,9 @@ export class ReviewService {
 	}
 
 	private async openNextNoteInQueue(noteSet: INoteSet): Promise<void> {
-		const errorMsgBase = `Error opening next note in note set ${noteSet.displayName}: `;
-		if (
-			noteSet.queue?.filenames?.length &&
-			noteSet.queue?.filenames?.length === 0
-		) {
-			this._plugin.showNotice(errorMsgBase + "review queue is empty.");
+		const errorMsgBase = `Error opening next note in note set ${noteSet.displayName}: \n`;
+		if (!noteSet.queue?.filenames?.length) {
+			this._plugin.showNotice(errorMsgBase + "review queue is empty. Check note set in plugin settings.");
 			return;
 		}
 		const filePath = noteSet.queue.filenames[0];