-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage reports differ when --optimization-counter-threshold=-1 is used #56075
Comments
//cc @liamappelbe @jensjoha |
https://dart-review.googlesource.com/c/sdk/+/370501 added coverage instructions at call sites (at the Closing this issue as duplicate to #42061. |
But doesn't |
That's right. However, sdk/runtime/vm/compiler/stub_code_compiler_x64.cc Lines 2313 to 2326 in f9cd243
That's a yet another reason to replace unreliable function usage counters with explicit |
Thanks for the explanation! |
@jensjoha Yes, we can apply your patch - adding |
The CFE team has made the change to use RecordCoverage to InstanceCall and StaticCall (see https://dart-review.googlesource.com/c/sdk/+/370501)
There seems to be a difference between the coverage results on normal runs Vs runs with the option
--optimization-counter-threshold=-1
Applying the following patch makes the results match up
It is unclear why this is needed.
The text was updated successfully, but these errors were encountered: