Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing a 1.0.0 release #199

Open
devoncarew opened this issue Dec 7, 2022 · 2 comments
Open

Consider publishing a 1.0.0 release #199

devoncarew opened this issue Dec 7, 2022 · 2 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@devoncarew
Copy link
Member

This would not necessarily contain breaking changes; publishing 1.0.0 would just indicate the maturity and support of this package.

@devoncarew
Copy link
Member Author

From a discussion, if we choose to rev. this to 1.0.0, doing this before package:checks is released would cause less work for the community (after that release, people will need an explicit dep on matcher in their pubspec in order to consume the package).

@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label Jan 25, 2023
@natebosch
Copy link
Member

We will want the 1.0 release to include expect, and AsyncMatcher and all the future/stream matchers, which are currently defined in package:test_api.

The next chunk of work is to move the definitions here, and re-export them in test from here instead of from test_api. We would remove the dependency on matcher from test_core and test_api.

The current sticking point is that tests of expect and especially expectAsync, rely on knowledge of the internals of the test runner for the runTestBody utility.

We work around this in checks currently but running in an error zone, and pumping the event queue to ensure the test ran and failed.

We might be able to use a similar pattern here for matcher, it is a little ugly, but I also don't know if it's ugly enough to justify new APIs in test_api for this use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
Status: On Deck
Development

No branches or pull requests

2 participants