Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging locks at the end of slidee #97

Closed
darsain opened this issue Oct 16, 2013 · 6 comments
Closed

Paging locks at the end of slidee #97

darsain opened this issue Oct 16, 2013 · 6 comments

Comments

@darsain
Copy link
Owner

darsain commented Oct 16, 2013

Continuation from sly forum issue.

Replicated: https://jsfiddle.net/pUSHJ/3/

Scroll to the end, prevPage stops working.

Suspect: Page generation loop generating too many pages in some edge cases.

I'll fix it when I'll have some time.

@mariusil
Copy link

if it helps, setting margin-right to 0 for the last item will make it work (at least on my case)

@darsain
Copy link
Owner Author

darsain commented Oct 19, 2013

You can try the development version with the fix from src/sly.js, but be aware that it has other untested stuff in it.

Specifically there is an overhaul of dragging initiation that interferes with (euphemism for "breaks") interactive elements inside of items. More on that in #27.

So if you are using dragging, and have an interactive elements (like inputs, checkboxes, and other form fields) inside of your items, you might want to test it out before using it.

@darsain
Copy link
Owner Author

darsain commented Oct 19, 2013

Sorry, I brain-farted, this is still broken.

@darsain darsain reopened this Oct 19, 2013
@darsain
Copy link
Owner Author

darsain commented Oct 20, 2013

Ok, it should be fixed now. Test from src/sly.js.

But this is still a development version with issue #27 unresolved.

@darsain
Copy link
Owner Author

darsain commented Oct 20, 2013

Again, the issue is still not fixed, and I'm now embarrassing myself.

@darsain
Copy link
Owner Author

darsain commented Oct 20, 2013

Now I've actually tested it with the replication of this issue, and it should finally be fucking fixed 💩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants