-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't use button on items if activateOn is set to 'click' #189
Comments
Yeah that Try replacing the function activateHandler(event) {
/*jshint validthis:true */
// Ignore clicks on interactive elements.
if (isInteractive(this)) {
event.originalEvent[namespace + 'ignore'] = true;
return;
}
// Ignore events that:
// - are not originating from direct SLIDEE children
// - originated from interactive elements
if (this.parentNode !== $slidee[0] || event.originalEvent[namespace + 'ignore']) return;
self.activate(this);
} If it works for you I'll release it in next patch. |
This seems to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Thanks for your awesome library!
I have a problem when trying to use a button on an sly item if activateOn is set to click : the button doesn't respond.
After debugging I find this function :
which cause the click event to be dropped on a button because by default buttons are "interactive". If I understand it, this is to prevent to start dragging when clicking on a button ?
Here is a exemple of the "item" code I am using. I use the twitter bootstrap framework to open a popup when clicking on the buttons (with data-toggle data-target) and the handler of bootstrap is never called because the sly one is called before and drop the event.
Any way to fix this ?
Thanks!
The text was updated successfully, but these errors were encountered: