fix(react): typescript and react version compatibility #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DaniAcu is attempting to deploy a commit to the darkroom Team on Vercel. A member of the Team first needs to authorize it. |
clementroche
approved these changes
Apr 9, 2024
|
thx @DaniAcu, it's merged. However
|
|
Thanks! Is it happening in building process? I will take a look why is this happend 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this 2 mistakes, first a small miss config in tsconfig and then a lot of typescript errors in the IDE.
I also add a support for react 17,the code is completely compatible but I don't know if is a priority for you guys or not, but I think is cool have this compatibility when is easy to be possible