try removing the nginx reverse-proxy for BwdServer

[pbiggar]

We have no real use for the nginx proxy for bwdserver, and it just provides another thing to configure and maintain. We need nginx for the apiserver and we used to have the apiserver and the bwdserver in the same process.

Let's try without it.

[pbiggar]

If we stick with this we'll need:

• DDOS protection (try cloud armor) as we used nginx to allow load-shedding
• a redirect for one customer
• similar gzip behaviour
• test "host" header in production - does it have the right port

[pbiggar]

• We'll need to update the changelog to say that the content-length needs to be right.

[pbiggar]

Need a test with what happens with incorrect content-length:

• too long
• too short

[edit: tests added]

[pbiggar]

• test the xforwarded for works in production

[pbiggar]

There was a bug I couldn't figure out when developing this. It turns out Kestrel really does not like you to have the wrong content-length. It manifested as a full 400 error being returned by Kestrel AFTER a response had already happened (just jammed right on the end of the HTTP output stream, and in some cases in the middle of it).

I speculate that nginx really didn't care that much which is why we didn't notice the tests were wrong.

[pbiggar]

• Remove "Kestrel" header

[pbiggar]

• check assets passed through via serveLatest work

[pbiggar]

• test "host" header in production - does it have the right port

Yes, no port exists. (in the url field either)

[pbiggar]

Note for when I come back to this:

• it seems that asp.net is using transfer-encoding a lot, but that's possibly because the APIs we're using are async or provide streams or something, while we actually have strings we could write in directly with a known content-length.

[pbiggar]

• check assets passed through via serveLatest work

Being handled in #3658

[pbiggar]

a redirect for one customer

There's two customers with a canvas that redirects, but it seems neither of them are terribly active, and there aren't any requests to the non-www version of their page anyway. We'll see if they complain.

[pbiggar]

Closing this - the remaining work in covered in #3664.