Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python3.8 support #64

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Add python3.8 support #64

merged 1 commit into from
Nov 23, 2019

Conversation

zhudotexe
Copy link
Contributor

@pep8speaks
Copy link

Hello @mommothazaz123! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 359:80: E501 line too long (82 > 79 characters)
Line 361:80: E501 line too long (103 > 79 characters)

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 98.451% when pulling 65ab6c5 on mommothazaz123:py38 into b47858d on danthedeckie:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 98.451% when pulling 65ab6c5 on mommothazaz123:py38 into b47858d on danthedeckie:master.

@zhudotexe zhudotexe mentioned this pull request Oct 29, 2019
Closed
@pokoli
Copy link

pokoli commented Nov 21, 2019

I've run on the same issue and I can confirm that this PR fixes the issue.

@danthedeckie danthedeckie merged commit 02ff5cd into danthedeckie:master Nov 23, 2019
@zhudotexe zhudotexe deleted the py38 branch November 24, 2019 02:01
@pokoli
Copy link

pokoli commented Nov 25, 2019

@danthedeckie Could you upload a new version with this fix to pypi?

This is a blocking Tryton to be used on Python3.8.

@daveisfera daveisfera mentioned this pull request Dec 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when running on python3.8
5 participants
@zhudotexe @pep8speaks @coveralls @pokoli @danthedeckie