Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exceptions due to services not loaded during EC startup #221

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

chishm
Copy link
Contributor

@chishm chishm commented Nov 23, 2020

Description

Add after_dependencies on the most commonly used control entity components to prevent attempts to use them during startup before they have been initialised. This fixes ServiceNotFound with Unable to find service light/turn_on and Unable to find service script/turn_on.

Checklist

  • The PR title is clear, concise and follows conventional commit formatting.
  • Double-check your branch is based on develop and targets develop
  • Issue raised to compliment this PR (if no pre-existing issue exists)
  • Code is commented, particularly in hard-to-understand areas and relevant issues are referenced.
  • Documentation repository updated to reflect new features or changes in behaviour (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • Description explains the issue/use-case resolved and auto-closes related issues.
  • Breaking changes or changes in behaviour are called out and discussed in separate issues.
  • Testing of new changes completed by person who raised the issue.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

License

By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license. Thank you for contributing!

Related Issues

Closes

Add after_dependencies on the most commonly used control entity components
to prevent attempts to use them during startup before they have been
initialised. This fixes `ServiceNotFound` with `Unable to find service
 light/turn_on` and `Unable to find service script/turn_on`.
@danobot danobot merged commit 48d5602 into danobot:develop Nov 23, 2020
@danobot
Copy link
Owner

danobot commented Nov 23, 2020

Thank you for your contribution! Appreciate it!

@chishm chishm deleted the fix-startup-exceptions branch December 3, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants