Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom State Strings and service data incorrect #218

Open
derekoharrow opened this issue Nov 17, 2020 · 0 comments
Open

Custom State Strings and service data incorrect #218

derekoharrow opened this issue Nov 17, 2020 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@derekoharrow
Copy link

(1) The custom state strings are defined in the source code and outlined here - https://danobot.github.io/ec-docs/special/state-strings.

  • control_states_on and control_states_off are defined, but not used in the source code, so do nothing.
  • state_states_off is defined, but not used in the source code at all

(2) Service data is defined here - https://danobot.github.io/ec-docs/config-advanced/custom-params

  • service_data and service_data off seem to be used, but service_data_on is not referenced in the source code at all. Looks like it just uses service_data for turn_on and service_data_off for turn_off.

Also, it would be great if the documentation of state-strings could be updated to provide examples, as it's really hard to tell what is support to do what and how it works.

Thanks

@danobot danobot added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants