Unnecessary variable copy

[mvalois]

Is that clone really necessary?

vaultwarden/src/api/admin.rs

Line 282 in 008a2cf

let email = data.email.clone();

Removing that line

vaultwarden/src/api/admin.rs

Line 287 in 008a2cf

let mut user = User::new(email);

and moving ownership with

let mut user = User::new(data.email);

seems to be valid.

[BlackDex]

PR's are more suited for this. But I'm fine adjusting this later during some admin updates.

[mvalois]

Fine, I just wanted to discuss about it, I doubted I was correct. I'll push a PR. Thanks.

[BlackDex]

Well, i think it was just an oversight during some other changes. email was used at more locations but was charged to use the new user instead i think.

[mvalois]

Sure. I thought rustc or clippy would've seen that.

[mvalois]

here it is #3981