Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dani-garcia/vaultwarden Loading
base: 1.28.0
Choose a base ref
...
head repository: dani-garcia/vaultwarden Loading
compare: 1.28.1
Choose a head ref
  • 16 commits
  • 29 files changed
  • 6 contributors

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    62cebeb View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3376 from jjlin/knowndevices-nopad

    Decode knowndevice `X-Request-Email` as base64url with no padding
    dani-garcia committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    525e6bb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Fix password reset issues

    There was used a wrong macro to produce an error message when mailing
    the user his password was reset failed. It was using `error!()` which
    does not return an `Err` and aborts the rest of the code.
    
    This resulted in the users password still being resetted, but not being
    notified. This PR fixes this by using `err!()`. Also, do not set the
    user object as mutable until it really is needed.
    
    Second, when a user was using the new Argon2id KDF with custom values
    like memory and parallelism, that would have rendered the password
    incorrect. The endpoint which should return all the data did not
    returned all the new Argon2id values.
    
    Fixes #3388
    
    Co-authored-by: Stefan Melmuk <[email protected]>
    BlackDex and stefan0xC committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    2cda54c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcaaa43 View commit details
    Browse the repository at this point in the history
  3. fmt

    nikolaevn committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0c085d2 View commit details
    Browse the repository at this point in the history
  4. always return KdfMemory and KdfParallelism

    the client will ignore the value of theses fields in case of `PBKDF2`
    (whether they are unset or left from trying out `Argon2id` as KDF).
    
    with `Argon2id` those fields should never be `null` but always in a
    valid state. if they are `null` (how would that even happen?) the
    client still assumes default values for `Argon2id` (i.e. m=64 and p=4)
    and if they are set to something else login will fail anyway.
    stefan0xC committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0daaa9b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. clear kdf memory and parallelism with pbkdf2

    when changing back from argon2id to PBKDF2 the unused parameters
    should be set to 0.
    
    also fix small bug in _register
    stefan0xC committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    39a5f2d View commit details
    Browse the repository at this point in the history
  2. add mail check

    nikolaevn committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    379f885 View commit details
    Browse the repository at this point in the history
  3. add check user state

    nikolaevn committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    aa6f774 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. Merge pull request #3390 from BlackDex/fix-abort-pw-reset-on-mail-error

    Fix abort on pw reset mail error
    dani-garcia committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    15dd05c View commit details
    Browse the repository at this point in the history
  2. Revert setcap, update rust and crates

    - Revert #3170 as discussed in #3387
      In hindsight it's better to not have this feature
    - Update Dockerfile.j2 for easy version changes.
      Just change it in one place instead of multiple
    - Updated to Rust to latest patched version
    - Updated crates to latest available
    - Pinned mimalloc to an older version, as it breaks on musl builds
    BlackDex committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    fc43608 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #3397 from nikolaevn/feature/add-admin-reinvite-en…

    …dpoint
    
    support `/users/<uuid>/invite/resend` admin api
    dani-garcia committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    d1ecf03 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3398 from stefan0xC/dont-expect-kdf-memory-or-par…

    …allelism
    
    always return KdfMemory and KdfParallelism
    dani-garcia committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    867c6ba View commit details
    Browse the repository at this point in the history
  5. Fix sending out multiple websocket notifications

    For some reason I encountered a strange bug which resulted in sending
    out multiple websocket notifications for the exact same user.
    
    Added a `distinct()` for the query to filter out multiple uuid's.
    BlackDex committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    bff54fb View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3405 from BlackDex/fix-multiple-websocket-messages

    Fix sending out multiple websocket notifications
    dani-garcia committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    c5bcc34 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #3403 from BlackDex/update-dockerfile-and-rust

    Revert setcap, update rust and crates
    dani-garcia committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    0b28ab3 View commit details
    Browse the repository at this point in the history
Loading