-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Comparing changes
Open a pull request
base repository: dani-garcia/vaultwarden
base: 1.28.0
head repository: dani-garcia/vaultwarden
compare: 1.28.1
- 16 commits
- 29 files changed
- 6 contributors
Commits on Mar 27, 2023
-
Decode knowndevice
X-Request-Email
as base64url with no paddingThe clients end up removing the padding characters [1][2]. [1] https://github.com/bitwarden/clients/blob/web-v2023.3.0/libs/common/src/misc/utils.ts#L141-L143 [2] https://github.com/bitwarden/mobile/blob/v2023.3.1/src/Core/Utilities/CoreHelpers.cs#L227-L234
Configuration menu - View commit details
-
Copy full SHA for 62cebeb - Browse repository at this point
Copy the full SHA 62cebebView commit details -
Merge pull request #3376 from jjlin/knowndevices-nopad
Decode knowndevice `X-Request-Email` as base64url with no padding
Configuration menu - View commit details
-
Copy full SHA for 525e6bb - Browse repository at this point
Copy the full SHA 525e6bbView commit details
Commits on Mar 30, 2023
-
There was used a wrong macro to produce an error message when mailing the user his password was reset failed. It was using `error!()` which does not return an `Err` and aborts the rest of the code. This resulted in the users password still being resetted, but not being notified. This PR fixes this by using `err!()`. Also, do not set the user object as mutable until it really is needed. Second, when a user was using the new Argon2id KDF with custom values like memory and parallelism, that would have rendered the password incorrect. The endpoint which should return all the data did not returned all the new Argon2id values. Fixes #3388 Co-authored-by: Stefan Melmuk <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2cda54c - Browse repository at this point
Copy the full SHA 2cda54cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcaaa43 - Browse repository at this point
Copy the full SHA dcaaa43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c085d2 - Browse repository at this point
Copy the full SHA 0c085d2View commit details -
always return KdfMemory and KdfParallelism
the client will ignore the value of theses fields in case of `PBKDF2` (whether they are unset or left from trying out `Argon2id` as KDF). with `Argon2id` those fields should never be `null` but always in a valid state. if they are `null` (how would that even happen?) the client still assumes default values for `Argon2id` (i.e. m=64 and p=4) and if they are set to something else login will fail anyway.
Configuration menu - View commit details
-
Copy full SHA for 0daaa9b - Browse repository at this point
Copy the full SHA 0daaa9bView commit details
Commits on Mar 31, 2023
-
clear kdf memory and parallelism with pbkdf2
when changing back from argon2id to PBKDF2 the unused parameters should be set to 0. also fix small bug in _register
Configuration menu - View commit details
-
Copy full SHA for 39a5f2d - Browse repository at this point
Copy the full SHA 39a5f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 379f885 - Browse repository at this point
Copy the full SHA 379f885View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa6f774 - Browse repository at this point
Copy the full SHA aa6f774View commit details
Commits on Apr 2, 2023
-
Merge pull request #3390 from BlackDex/fix-abort-pw-reset-on-mail-error
Fix abort on pw reset mail error
Configuration menu - View commit details
-
Copy full SHA for 15dd05c - Browse repository at this point
Copy the full SHA 15dd05cView commit details -
Revert setcap, update rust and crates
- Revert #3170 as discussed in #3387 In hindsight it's better to not have this feature - Update Dockerfile.j2 for easy version changes. Just change it in one place instead of multiple - Updated to Rust to latest patched version - Updated crates to latest available - Pinned mimalloc to an older version, as it breaks on musl builds
Configuration menu - View commit details
-
Copy full SHA for fc43608 - Browse repository at this point
Copy the full SHA fc43608View commit details -
Merge pull request #3397 from nikolaevn/feature/add-admin-reinvite-en…
…dpoint support `/users/<uuid>/invite/resend` admin api
Configuration menu - View commit details
-
Copy full SHA for d1ecf03 - Browse repository at this point
Copy the full SHA d1ecf03View commit details -
Merge pull request #3398 from stefan0xC/dont-expect-kdf-memory-or-par…
…allelism always return KdfMemory and KdfParallelism
Configuration menu - View commit details
-
Copy full SHA for 867c6ba - Browse repository at this point
Copy the full SHA 867c6baView commit details -
Fix sending out multiple websocket notifications
For some reason I encountered a strange bug which resulted in sending out multiple websocket notifications for the exact same user. Added a `distinct()` for the query to filter out multiple uuid's.
Configuration menu - View commit details
-
Copy full SHA for bff54fb - Browse repository at this point
Copy the full SHA bff54fbView commit details -
Merge pull request #3405 from BlackDex/fix-multiple-websocket-messages
Fix sending out multiple websocket notifications
Configuration menu - View commit details
-
Copy full SHA for c5bcc34 - Browse repository at this point
Copy the full SHA c5bcc34View commit details -
Merge pull request #3403 from BlackDex/update-dockerfile-and-rust
Revert setcap, update rust and crates
Configuration menu - View commit details
-
Copy full SHA for 0b28ab3 - Browse repository at this point
Copy the full SHA 0b28ab3View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.28.0...1.28.1