-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: SilentRenewFailed never gets fired #1649
Comments
@FabianGosebrink Is there any news about this issue? Should I clarify the issue better? I could create a fork. Let me know |
Thanks for reaching out. I have to have a look, maybe on the weekend if I find time. If you want to create a fork and a PR, so support this, I'd appreciate it. |
#1655 |
I have encountered similar results, the EventType of 11 is never fired even though the connect/token is failing on a refresh event
|
@Tyler-V fancy seeing you here. We're having all the same problems. |
Version
15.0.2
Please provide the exception or error you saw
The event
this.publicEventsService.fireEvent(EventTypes.SilentRenewFailed, error);
never gets called, because theunsubscribe
from the Observable gets called, before thecatchError
block is reached.This error was quite tricky to debug, because of the depth of the different pipes.
In the
RefreshSessionRefreshTokenService
in thecatchError
theintervalService
gets called, to stop the periodic tokencheck (if an error occurs -> i.e. the accessToken could not be refreshed).The
intervalService
then unsubscribes the periodical tokencheck and thecatchError
block in/periodically-token-check.service.ts
never gets called.A quick fix of the problem would be to move the
this.intervalService.stopPeriodicTokenCheck();
to the catchError-block in/periodically-token-check.service.ts
torefreshEventWithErrorHandler$
. So that the unsubscribe happens there.Steps to reproduce the behavior
Provoke an error in the silent renew request.
A clear and concise description of what you expected to happen.
EventTypes.SilentRenewFailed to be fired.
The text was updated successfully, but these errors were encountered: