Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: allow option to disable nonce parameter and check #1560

Open
tanandre opened this issue Oct 21, 2022 · 2 comments
Open

[Feature Request]: allow option to disable nonce parameter and check #1560

tanandre opened this issue Oct 21, 2022 · 2 comments

Comments

@tanandre
Copy link

There are auth servers that do not support the nonce parameter. And as a client it is not required to send one. This flexibility allows angular-auth-oidc-client to be applicable in more different situations and environments.

Describe the solution you'd like
A configurable option to disable the nonce parameter and validation

Describe alternatives you've considered
We tried convincing the other side to support nonce but this is hard to control. Also we added a workaround to disable the nonce validation by updating the sessionStorage before angular-auth-oidc-client reads it, but this seems very hacky and brittle and can easily break with each upgraade.

Additional context
Add any other context or screenshots about the feature request here.

@damienbod
Copy link
Owner

Why would you disable the nonce validation? This is a important security check.

Get it working due to env constraints with security holes is not really a good idea. Is updating your identity provider to a modern standard not possible?

Greetings Damien

@tanandre
Copy link
Author

tanandre commented Nov 1, 2022

Hi Damien,

Our application is setup to connect with multiple different OIDC servers depending on what our customers use. Most of the OIDC servers we connected to support the nonce but we currently encountered one that doesn't. We already pushed back by explaining it's mandatory for the server to support it. Still, as a client it is an optional parameter which I believe we could make it configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants