Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Periodic silent renew check keep hapenning after logoff #1401

Open
agardiol opened this issue Mar 9, 2022 · 2 comments
Open

[Bug]: Periodic silent renew check keep hapenning after logoff #1401

agardiol opened this issue Mar 9, 2022 · 2 comments

Comments

@agardiol
Copy link

agardiol commented Mar 9, 2022

What Version of the library are you using?
13.1.0

Describe the bug
I use an openid flow with the following options:

      scope: 'openid read write',
      responseType: 'code',
      silentRenew: true,
      useRefreshToken: true,

After a successful authentication, if I call the logoff method (my auth server does not have a revoke token endpoint), the library keep running periodically the silent renew check:
image

To Reproduce
Run the following code:
this.oidcSecurityService.authorize();
Complete the logon process
this.oidcSecurityService.logoff(); to log off
Check the log

Expected behavior
After a logoff, the library should stop checking periodically if a silent renew has to be done.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 99.0.4844.51 (Build officiel) (64 bits)
@damienbod
Copy link
Owner

damienbod commented Mar 15, 2022

It doesn't check the server, just logs that the code validates if it needs to do something periodically. Maybe this could be improved

Thanks for reporting

Greetings Damien

@agardiol
Copy link
Author

Thanks for you answer.
Yes, you are right, there is no data exchange with the server. However, in logoff code, it should call IntervalService.stopPeriodicTokenCheck() somewhere (maybe in resetAuthorizationData function in reset-auth-data.service.ts.
Best regards Antoine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants