Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception handling in PwFido2SignInController.cs #12

Closed
nicowitteman opened this issue Jan 20, 2021 · 2 comments
Closed

Exception handling in PwFido2SignInController.cs #12

nicowitteman opened this issue Jan 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@nicowitteman
Copy link

Hi Damien, I propose to move the "throw new ArgumentException("Username was not registered");" a few lines up: instead of checking the existence of the user, check the existence of the identityUser, for when that is empty, the new FidoUser will throw an uncaught exception. Suggestion: if (identityUser == null) throw new ArgumentException("Username was not registered");

@damienbod damienbod added the enhancement New feature or request label Jan 20, 2021
@damienbod
Copy link
Owner

I will add this when updating to version 3 of the FIDO2 lib

@nicowitteman
Copy link
Author

I cerated pull request #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants