-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception handling in PwFido2SignInController.cs #12
Labels
enhancement
New feature or request
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Damien, I propose to move the "throw new ArgumentException("Username was not registered");" a few lines up: instead of checking the existence of the user, check the existence of the identityUser, for when that is empty, the new FidoUser will throw an uncaught exception. Suggestion: if (identityUser == null) throw new ArgumentException("Username was not registered");
The text was updated successfully, but these errors were encountered: