Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MfaFido2SignInFidoController constructor #10

Closed
nicowitteman opened this issue Jan 10, 2021 · 3 comments
Closed

MfaFido2SignInFidoController constructor #10

nicowitteman opened this issue Jan 10, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@nicowitteman
Copy link

nicowitteman commented Jan 10, 2021 •
edited
Loading

Hi Damien, the MfaFido2SignInFidoController constructor contains this statement twice: "_userManager = userManager;" while it is not even used at all.
And while we're at it, wouldn't it be logical to include the result of the await _signInManager.TwoFactorSignInAsync("FIDO2", string.Empty, false, false) in the return value of the MakeAssertion call, or is this covered by the exception handler?
Nico
@damienbod
Copy link
Owner

Thanks, I must clean thi part up, thanks for reporting.

I'll fix this in the next few days. Or if you want to do a PR, would also be good.

Greetings Damien

@damienbod damienbod added the bug Something isn't working label Jan 10, 2021
@nicowitteman
Copy link
Author

I'll leave it to you, if you don't mind.

@damienbod
Copy link
Owner

fixed, thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienbod @nicowitteman