feat: add alert failure event #7238
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). dagit-storybook – ./js_modules/dagit/packages/ui🔍 Inspect: https://vercel.com/elementl/dagit-storybook/7dmATNWbWaDqwh6j8pMFnfmT8QVM [Deployment for 7f6a2be canceled] dagster – ./docs/next🔍 Inspect: https://vercel.com/elementl/dagster/4RoWApx27SxNrwUo4oKGqM9kc1We [Deployment for 7f6a2be canceled] |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
fee7613
to
33b7d73
Compare
33b7d73
to
7f6a2be
Compare
| return <DefaultContent eventType={eventType} message={node.message} eventIntent="success" />; | ||
| case 'AlertFailureEvent': | ||
| return <DefaultContent eventType={eventType} message={node.message} eventIntent="warning" />; |
There was a problem hiding this comment.
While we're at it, let's differentiate these events with intent.
|
Will hold off on merging this until we have certainty that this is backwards compatible with old dagster versions. This event will be reported outside of the job context, which is why there could be issues interpreting this event if they are on an old version. |
Summary
At long last, we finally need this event.
Test Plan
internal