fix: prevent runs filter from accepting an empty list of run ids

[rexledesma]

Summary

Currently, applying a run filter with run_ids as None or [] has the same result of fetching all the runs. This is because both values are falsey.

We could change the logic to treat [] as a short-circuit and skip fetching any runs, but then the API consumer would need to be wary that passing in [] has this particular behavior.

Instead, if [] is passed in, throw an error. The API consumer should explicitly guard for this case in their business logic, rather than relying on the underlying API to skip the fetching of any runs.

Test Plan

pytest

run dagit locally, fill out id: field with random values

Screen.Recording.2022-03-28.at.2.46.46.PM.mov

[linear]

CLOUD-1165 Throw an error if runs filter is given an empty list of run ids

Currently, applying a run filter with run_ids as None or [] has the same result of fetching all the runs. This is because both values are falsey.

We could change the logic to treat [] as a short-circuit and skip fetching any runs, but then the API consumer would need to be wary that passing in [] has this particular behavior.

Instead, if [] is passed in, throw an error. The API consumer should explicitly guard for this case in their business logic, rather than relying on the underlying API to skip the fetching of any runs.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/7Uxy1SjNtYytAfWdJ2He3KAoqJKy
✅ Preview: Canceled

[Deployment for 77c483b canceled]

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/3H9k29ejHqWbVuL7mbosgVKR9x2B
✅ Preview: Canceled

[Deployment for 77c483b canceled]

[rexledesma]

Current dependencies on/for this PR:

• master
  • PR fix: prevent runs filter from accepting an empty list of run ids #7217 (this PR)

This comment was auto-generated by Graphite.

[alangenfeld]

Test Plan
pytest

can you do a quick sanity check in dagit to make sure you can't get this fire messing around with filters in the runs page?

[rexledesma]

Test Plan
pytest

can you do a quick sanity check in dagit to make sure you can't get this fire messing around with filters in the runs page?

Locally verified this behavior and added a video. Though funny enough, found an unrelated error when doing this manual test (#7219).

[alangenfeld]

thanks