Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clarify the top level graphene query/mutation/subscription #5782

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

rexledesma
Copy link
Member

Summary

Open source change to accompany https://github.com/dagster-io/internal/pull/507. Felt these names were ungreppable and confusing (are they our implementations, or are they imported from the Graphene library?)

Test Plan

See what breaks, and fix.

@vercel
Copy link

vercel bot commented Nov 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/6sL5Btk6rsvXPb7icNCDcc7qijP4
✅ Preview: Canceled

[Deployment for 7abd0ce canceled]

@rexledesma
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open.

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully support renaming the python class name - renaming the Graphql type name will require some changes on the JS side (grep for "Query" or "Mutation", some tests use it and check the typename) - I don't think it will be a user-facing breaking change though unless they have some strange queries?

@rexledesma
Copy link
Member Author

Updated https://github.com/dagster-io/internal/pull/507 as the corresponding change to unbreak internal

@hellendag
Copy link
Member

You may also need to change the Query: in AppCache, but I'm actually thinking maybe we don't need that typePolicies anymore anyway...

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal builds are failing but i assume there's a separate PR for that

@rexledesma rexledesma merged commit 9d9e937 into master Nov 29, 2021
@rexledesma rexledesma deleted the rl/rename-queries branch November 29, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants