refactor(dagit): remove append generated #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/elementl/dagster/6FKLzjnLnG7yHfzrTHQYrxaQqhQw [Deployment for 266ef39 canceled] |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open. |
f22307a
to
69dc75e
Compare
bengotow
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
This looks good to me @rexledesma, sorry for the merge conflicts - we renamed some of the components and their generated queries.
If you want to re-run this and merge I think that'd be great!
69dc75e
to
266ef39
Compare
mgasner
pushed a commit
that referenced
this pull request
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ignore generated graphql files from PR review using
.gitattributes, rather than@generated.Test Plan
See generated files ignored in PRs.