[dagster-aws] add ECSExecutor #26098
Draft
+404
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddefa55
to
0b99a6a
Compare
Summary: Proving out the possibility of building out an ECS executor. It assumes that it is launched via the EcsRunLauncher and can use the same task definition of the task in which it is launched, but still allows customizing of memory,cpu, ephemeral storage, and whatever else you can override via run_task arguments.
0b99a6a
to
56bd783
Compare
Comment on lines
+329
to
+331
| def check_step_health( | ||
| self, step_handler_context: StepHandlerContext, step_identifier: Optional[str] | ||
| ) -> CheckStepHealthResult: |
There was a problem hiding this comment.
The parameter name step_identifier should be renamed to step_worker_handle to match the base class interface in StepHandler. This ensures consistent naming across the codebase and proper adherence to the interface contract.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR ads a new ECS Tasks Executor.
How I Tested These Changes
Changelog
Insert changelog entry or "NOCHANGELOG" here.
NEW(added new feature or capability)BUGFIX(fixed a bug)DOCS(added or updated documentation)