[ui] Fix unnecessary middle truncation occurring in dialogs #26086
+37
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 2bca56d. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 2bca56d. |
hellendag
approved these changes
Nov 21, 2024
salazarm
reviewed
Nov 21, 2024
| const width = container.getBoundingClientRect().width; | ||
|
|
||
| // https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Determining_the_dimensions_of_elements#how_much_room_does_it_use_up | ||
| const width = container.offsetWidth; |
There was a problem hiding this comment.
Not caused by your PR but can we wrap the usage of calculateMiddleTruncatedText in a requestAnimationFrame since accessing offsetWidth triggers a forced layout.
salazarm
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
https://linear.app/dagster-labs/issue/FE-684/targeted-assets-dialog-is-too-aggressive-with-middle-truncate
Thankfully this turned out to be a quick fix - I verified in the docs that
offsetWidthshouldn't have other implications beyond this:How I Tested These Changes
Tested manually in the "Upstream assets modal" with some long asset names and also via a new storybook + verification that no other MiddleTruncate storybooks were impacted.
Changelog
[ui] Fixed unnecessary middle truncation occurring in dialogs.