Fix bug in projectAsLibrary test

[keyboardDrummer]

Description

• Fix bug in projectAsLibrary test

How has this been tested?

• Existing test now completes in 1 seconds instead of getting stuck. Not sure how it ever passes in CI, but there it was taking a huge time to complete.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

[robin-aws]

Fix itself LGTM - checking my understanding, the problem was incorrectly thinking a dependency did not have compatible options, and therefore falling back to verifying the dependency when that wasn't the intent?

I'm a little worried this is a big foot gun for users to hit in the same way if so.

[keyboardDrummer]

Fix itself LGTM - checking my understanding, the problem was incorrectly thinking a dependency did not have compatible options, and therefore falling back to verifying the dependency when that wasn't the intent?

No. The problem was dat --libraries was considered a non-semantic option, meaning it is copied from the root project to the dependency, causing the dependency to have itself as a dependency which caused a cycle in the compilation process.

I've refactored this PR, so the resulting code is now simpler.

[robin-aws]

I do think we need another category of options rather than special-casing --library, but this is a good improvement for now.

I'm also very worried about a test that apparently should fail but instead takes a long time and then passes! But I don't think leaving this test in this state is a good idea just to not lose track of that problem.