Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import Collections library #4756

Merged

Conversation

alex-chew
Copy link
Contributor

This PR imports the Collections libraries from dafny-lang/libraries, as a new DafnyStdLibs library.

Note that the LittleEndianNat and LittleEndianNatConversions libraries are not imported, as there is still work required to enable different verification flags in the standard libraries (particularly --disable-nonlinear-arithmetic as desired for these libraries).

Description

How has this been tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge once the dependency Arithmetic is in, especially to unblock other libraries that depend on it. There are a couple of things to follow up on afterwards though:

@alex-chew alex-chew marked this pull request as ready for review November 13, 2023 21:54
@alex-chew alex-chew enabled auto-merge (squash) November 13, 2023 21:54
Copy link
Member

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind on my previous review - didn't realize that Math had definitions that aren't already in Arithmetic. The distinction is not common in standard libraries, but I think Dafny's allowed to be more precise than usual. :)

@alex-chew alex-chew merged commit 9bdbd49 into dafny-lang:master Nov 13, 2023
20 checks passed
@alex-chew alex-chew deleted the feat/libraries-collections-sans-examples branch November 13, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants