Fix: Support for Corretto tests #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
Mar 13, 2023
Comment on lines
3420
to
3421
| wr.Write("\"" + Dafny.ErrorReporter.TokenToString(tok).Replace( | ||
| @"\", @"\\") + ": \" + "); |
There was a problem hiding this comment.
Suggested change
| wr.Write("\"" + Dafny.ErrorReporter.TokenToString(tok).Replace( | |
| @"\", @"\\") + ": \" + "); | |
| wr.Write("\"" + TranslateEscapes(Dafny.ErrorReporter.TokenToString(tok)) + ": \" + "); |
The root cause is printing out a string without any escaping (nothing to do with Corretto AFAICT).
It looks like all compilers have the same issue in EmitHalt, so worth applying the same fix consistently if possible.
There was a problem hiding this comment.
I did not use "TranslateEscapes" because it's not an escaping function. It's actually taking the source of a Dafny string and translating escapes to Java Escapes. Here, the only thing in PATHs that could be problematics is the backward slash.
There was a problem hiding this comment.
Actually my mistake, you want EmitStringLiteral(..., true, wr)
…/dafny into fix-3731-test-on-java
davidcok
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3731, which will enable me to reproduce #3724 locally.
I did not add tests for now because this bug appears on Windows + Corretto machines, and I just switched to Corretto. I'm not expecting to change the CI pipeline until we decide so.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.