Omit empty modules from translation records #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
changed the title
…n-aws/dafny into omit-empty-modules-from-translation
| @@ -1,11 +1,13 @@ | |||
| // RUN: %baredafny translate cs %args %S/Inputs/Foo.dfy &> %t | |||
There was a problem hiding this comment.
Why %baredafny translate instead of %translate ?
keyboardDrummer
approved these changes
May 22, 2024
lucasmcdonald3
added a commit
to lucasmcdonald3/dafny
that referenced
this pull request
Jun 4, 2024
This reverts commit 4ce2f7e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5459
Omits modules that only contain other modules from translation records, since they can appear in multiple different separately-compiled libraries when they are prefix modules (i.e. a module
A.Bthat only appears in amodule A.B.C { ... }declaration).I attempted to omit such modules from translation entirely at first, but hit issues in the Go backend. It may be possible to do so in the future with more care.
How has this been tested?
Updated
DuplicateModules.dfyto include parent modules.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.